Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add functionality to remove prefix '(P)' when cleaning ratings #28

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

a-vester
Copy link
Member

@a-vester a-vester commented Dec 5, 2022

Estimated time: 5-10 min


Some ratings may have a prefix '(P)', which indicates that this rating is based on public information only. It is comparable to the suffix 'u' (unsolicited).

This commit improved get_pure_ratings in order to also remove this kind of prefix.

Closes #27

Some ratings may have a prefix '(P)', which indicates that this rating
is based on public information only. It is comparable to the suffix 'u'
(unsolicited).

This commit improved ``get_pure_ratings`` in order to
also remove this kind of prefix.

Closes #27
@a-vester a-vester added enhancement New feature or request refactor Refactoring code without introducing new features. labels Dec 5, 2022
Copy link
Collaborator

@deepakparashar1987 deepakparashar1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-vester a-vester merged commit 9fa6d81 into main Dec 6, 2022
@a-vester a-vester deleted the update_get_pure_ratings_27 branch December 6, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactoring code without introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Clean "(P)" in front of Moody's ratings
2 participants