Fixed UB in big5::tests::test_big5_decode flagged by Miri. #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the out-of-bound UB in #52.
Looks like replacing
dst.add
withdst.wrapping_add
is sufficient to stop UB from occurring, while passing all existing test cases.Run
cargo miri test -- -Zmiri-disable-alignment-check -- big5::tests::test_big5_decode
to confirm that the UB is fixed.