Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert hslayers-server from CommonJS to ES module #3816

Closed
jmacura opened this issue Feb 15, 2023 · 1 comment · Fixed by #4654
Closed

Convert hslayers-server from CommonJS to ES module #3816

jmacura opened this issue Feb 15, 2023 · 1 comment · Fixed by #4654
Assignees
@jmacura
Labels
enhancement refactoring server
Milestone
server 2.0

Comments

@jmacura
Copy link
Collaborator

jmacura commented Feb 15, 2023

Feature Request

Is your feature request related to a problem? Please describe.
hslayers-server uses CommonJS syntax, some packages like "got" already moved to a "pure" ES modules standard.

Describe the solution you'd like
Refactor files from CJS to ESM

Describe alternatives you've considered
Leave it be until it breaks on some future Node version.

Additional context
Mixing CJS and ESM modules requires hacks like dynamic imports (see e.g. #3815 )
@jmacura jmacura added this to the Future milestone Feb 15, 2023
@fzadrazil
Copy link
Collaborator

Solve #3858 while refactoring the server.

@jmacura jmacura assigned jmacura and unassigned fzadrazil Jan 23, 2024
@jmacura jmacura mentioned this issue Jan 23, 2024
Merged
17 tasks
@jmacura jmacura modified the milestones: Future, server 2.0 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacura jmacura

Labels
enhancement refactoring server
Projects
None yet
Milestone
server 2.0
Development

Successfully merging a pull request may close this issue.

Create tests for hslayers-server and convert CommonJS files to ES syntax hslayers/hslayers-ng
2 participants
@jmacura @fzadrazil