Create tests for hslayers-server and convert CommonJS files to ES syntax #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using Mocha framework and Chai expect & refactor(server): Rewrite CommonJS to ES modules
jmacura
force-pushed
the
issue-4635/proxy-replace
branch
2 times, most recently
from
12c4cc3 to
ba35e99
Compare
Bumps minimum Node version to 16 due to "got" Fixes better-sqlite3 installation problems with node-gyp
to allow easier debugging
Shall fix "version GLIBC_2.29 not found" error produced on older Linux systems
jmacura
force-pushed
the
issue-4635/proxy-replace
branch
from
3cb8b90 to
78411fb
Compare
|
|
Until now, if there were multiple "?" in the URL and thus multiple search-params, only the first were taken. With this commit, all search params are resent to the remote server
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } catch (ex) { | ||
| res.writeHead(500, { 'Content-Type': 'text/plain' }); | ||
| res.write('Invalid request'); | ||
| res.write(ex); |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace Medium
jmacura
force-pushed
the
issue-4635/proxy-replace
branch
from
9692293 to
cd398ac
Compare
Ignore hslayers-server changes with original workflow
jmacura
force-pushed
the
issue-4635/proxy-replace
branch
from
cd398ac to
6c5d80c
Compare
FilipLeitner
approved these changes
Feb 5, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Mocha framework and Chai assertion library as new dependencies for the server.
Rewritten all CommonJS modules to ES modules with updated imports/exports.
Bumps minimum Node version to 16 due to "got"
Related issues or pull requests
closes #3816
closes #4651
fixes #4635
fixes #4650 via a cherry-picked commit from #4678
does not affect #3858 – albeit cors-anywhere last version was published 3 years ago, I haven't found any suitable alternative
Upgraded dependencies fix better-sqlite3 installation problems with node-gyp and glibc
Pull request type
Please check the type of change your PR introduces:
Do you introduce a breaking change?
Checklist
npm testlocally)