Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition layer order (issue 4679) #4721

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Composition layer order (issue 4679) #4721

merged 3 commits into from
Feb 23, 2024

Conversation

FilipLeitner
Copy link
Collaborator

@FilipLeitner FilipLeitner commented Feb 21, 2024 •
edited
Loading

Description

  • fix zindex assignment of composition layers -> should match the composition layer order and not be influenced by path's max zindex
  • sort layers in folder based on hsConfig.reverseLayerList

Related issues or pull requests

fixes #4679

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the [MIT License]
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@jmacura jmacura changed the title Issue 4679 - composition layer order Composition layer order (issue 4679) Feb 22, 2024
jmacura
jmacura reviewed Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@jmacura jmacura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos, but the change is a no-brainer.

projects/hslayers/common/extensions/layer-extensions.ts Outdated Show resolved Hide resolved
projects/hslayers/shared/layer-manager/layer-manager.service.ts Outdated Show resolved Hide resolved
@FilipLeitner @jmacura
chore: Comment typos
6be2a60 
Co-authored-by: jmacura <jmacura@users.noreply.github.com>
@jmacura jmacura merged commit 175e116 into develop Feb 23, 2024
4 checks passed
@jmacura jmacura deleted the compo-order-issue-4679 branch February 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacura jmacura jmacura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preserve composition layer order - in terms of zindex
2 participants
@FilipLeitner @jmacura