-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive HsCesium for version 14 #4749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
jmacura
changed the title
[WIP] Revive HsCesium for version 14
Revive HsCesium for version 14
Mar 19, 2024
+ cesium-test-app: Add example of a 3D (2.5D) GeoJSON refs #4757
...using 'extrudedHeight' property on layer
jmacura
force-pushed
the
cesium-fixes-14
branch
from
March 20, 2024 23:40
417b32e
to
0ea4118
Compare
jmacura
force-pushed
the
cesium-fixes-14
branch
from
March 20, 2024 23:41
0ea4118
to
5c2057c
Compare
FilipLeitner
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More effort is needed. HsCesium currently does not compile due to gazillion of "... 'rootDir' is expected to contain all source files
" errors. Probably Project References may help here, but I did not succeed in this matter yet. Any help appreciated.Related:
UPDATE:
The problem was simply in the fact that hslayers lib was not compiled beforehand. Project references might solve that, but I fail to implement them, hence I keep the "path" way to link hslayers and hslayers-cesium for now.
TODO:
Related issues or pull requests
fixes #4048
fixes #4750
port of #4751
Pull request type
Please check the type of change your PR introduces:
Do you introduce a breaking change?
Checklist
npm test
locally)