Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive HsCesium for version 14 #4749

Merged
merged 14 commits into from
Mar 22, 2024
Merged

Revive HsCesium for version 14 #4749

merged 14 commits into from
Mar 22, 2024

Conversation

jmacura
Copy link
Collaborator

@jmacura jmacura commented Feb 26, 2024

Description

More effort is needed. HsCesium currently does not compile due to gazillion of "... 'rootDir' is expected to contain all source files" errors. Probably Project References may help here, but I did not succeed in this matter yet. Any help appreciated.

Related:

UPDATE:
The problem was simply in the fact that hslayers lib was not compiled beforehand. Project references might solve that, but I fail to implement them, hence I keep the "path" way to link hslayers and hslayers-cesium for now.

TODO:

  • move 3D view toggle button somewhere else (toolbar?)
  • differentiate 3D view toggle button when 3D on/off

Related issues or pull requests

fixes #4048
fixes #4750
port of #4751

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the [MIT License]
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@jmacura jmacura marked this pull request as draft February 26, 2024 20:40
@jmacura jmacura added this to the 14.0 milestone Feb 26, 2024
@jmacura jmacura mentioned this pull request Feb 26, 2024
17 tasks
@jmacura jmacura changed the title [WIP] Revive HsCesium for version 14 Revive HsCesium for version 14 Mar 19, 2024
@jmacura
Copy link
Collaborator Author

jmacura commented Mar 20, 2024

Adds testing files to cesium-test-app for GeoJSON source and KML source.
image

Moves Cesium/OL 3D/2D toggle button from sidebar to toolbar. The background colour indicates the 3D view is active.
Before: image
After: image

@jmacura
Copy link
Collaborator Author

jmacura commented Mar 20, 2024

After incorporating the latest changes from develop, the toolbar actually looks like
image

@jmacura jmacura marked this pull request as ready for review March 20, 2024 23:52
@jmacura jmacura merged commit 6351f4d into develop Mar 22, 2024
4 checks passed
@jmacura jmacura deleted the cesium-fixes-14 branch March 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basemap not visible in Cesium Visibility state in LayerManager not propagated to Cesium
2 participants