Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes v15 - swipe layer render, map layers order, catalogue remove #5338

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

FilipLeitner
Copy link
Collaborator

@FilipLeitner FilipLeitner commented Oct 15, 2024

Description

Fixes for few bugs:

  • messy rendering of map-swipe layers caused by swipe position not set correctly
  • Sort layers inside folders. Currently only folders were sorted, layers themselves where displayed in inital order
  • Layers not being removed from map when executed from catalgoue as a result of incorrectly set layer name.

Along that :

  • give priority to the property values in layerOptions over those in service defults
  • Unify use_tiles and useTiles properties used in add-data

Related issues or pull requests

Please list issues or pull requests that the changes you propose are related to. It does not matter if they are still open and/or unmerged, any link is appreciated.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the [MIT License]
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@FilipLeitner FilipLeitner requested a review from jmacura as a code owner October 15, 2024 09:34
@FilipLeitner FilipLeitner added this to the 15.0 milestone Oct 15, 2024
@FilipLeitner FilipLeitner self-assigned this Oct 15, 2024
Copy link
Collaborator

@jmacura jmacura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. You can address the comment about function signature, if you agree.

@FilipLeitner FilipLeitner merged commit 3ac6d7e into develop Oct 21, 2024
5 checks passed
@jmacura jmacura deleted the fixes-v15 branch October 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map-swipe: Map-swipe layers not rendering correctly Catalogue: Remove layer
2 participants