Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema 3.0.0 #11

Merged
merged 7 commits into from
Sep 23, 2023
Merged

Schema 3.0.0 #11

merged 7 commits into from
Sep 23, 2023

Conversation

fzadrazil
Copy link
Collaborator

  • Breaking: Remove obsolete HSLayers.Layer.WMS and OpenLayers.Layer.Vector layer types
  • support WMTS layer type

@fzadrazil fzadrazil requested review from jirik, honza2, FilipLeitner and index-git and removed request for honza2 August 2, 2023 13:58
@fzadrazil
Copy link
Collaborator Author

I would also like to target this #10 in the PR. Does anyone has any idea of the meaning or possible usage of the "urls" parameter?

@FilipLeitner
Copy link
Collaborator

I would also like to target this #10 in the PR. Does anyone has any idea of the meaning or possible usage of the "urls" parameter?

Not used in hslayers anymore.

@jirik jirik mentioned this pull request Aug 7, 2023
Closed
@jirik
Copy link
Collaborator

jirik commented Aug 7, 2023

I would also like to target this #10 in the PR. Does anyone has any idea of the meaning or possible usage of the "urls" parameter?

Not used in Layman.

jmacura
jmacura reviewed Aug 8, 2023
View reviewed changes
schema.json Show resolved Hide resolved
@fzadrazil fzadrazil requested a review from jmacura August 28, 2023 12:38
@fzadrazil
Copy link
Collaborator Author

Any relevant reason to have hs.format there?

map-compositions/schema.json

Lines 539 to 541 in b273d6a

"hs.format.WFS",
"hs.format.externalWFS",
"hs.format.Sparql"

Wouldn't be better to have just eg. 'WFS'?

@jirik
Forbid encoded URLs in some keys
6dca65d 
- layers..url
- layers..legends.
- layers..protocol.url
index-git
index-git suggested changes Sep 5, 2023
View reviewed changes
schema.json Outdated
@@ -456,17 +456,18 @@
"description": "Big type of layer. Currently all raster layers are wms layers and Vector layers are subdivided by protocol property",
"default": "",
"enum": [
"HSLayers.Layer.WMS",
"OpenLayers.Layer.Vector",
"WMS",
"WMS",
"WFS",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ClassName: WFS" is never used, I suggest to remove it also.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used in HSLayers either. But wouldn't it be future-proof to keep the WFS classname as an allowed value?

@jmacura
Copy link

jmacura commented Sep 8, 2023

Any relevant reason to have hs.format there?

map-compositions/schema.json

Lines 539 to 541 in b273d6a

"hs.format.WFS",
"hs.format.externalWFS",
"hs.format.Sparql"

Wouldn't be better to have just eg. 'WFS'?

We would need to ask @raitisbe as the original author, but I suppose the idea was to keep the structure of OpenLayers' class names for formats, e.g. ol/format/KML. And as WFS was not one of formats provided by OpenLayers by that time, it became hs.format instead of ol.format...

@fzadrazil fzadrazil merged commit 58ed40d into main Sep 23, 2023
@fzadrazil fzadrazil deleted the feat-wmts branch September 23, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacura jmacura jmacura approved these changes

@index-git index-git index-git approved these changes

@FilipLeitner FilipLeitner FilipLeitner approved these changes

@jirik jirik Awaiting requested review from jirik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fzadrazil @FilipLeitner @jirik @jmacura @index-git