Task args no longer pick up values from the shell environment.

htanata · Feb 5, 2010 · 5148aac · 5148aac
1 parent 60ad5d9
commit 5148aac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/lib/rake/task_arguments.rb b/lib/rake/task_arguments.rb
@@ -64,10 +64,6 @@ def inspect
     def lookup(name)
       if @hash.has_key?(name)
         @hash[name]
-      elsif ENV.has_key?(name.to_s)
-        ENV[name.to_s]
-      elsif ENV.has_key?(name.to_s.upcase)
-        ENV[name.to_s.upcase]
       elsif @parent
         @parent.lookup(name)
       end

diff --git a/test/lib/task_arguments_test.rb b/test/lib/task_arguments_test.rb
@@ -50,12 +50,12 @@ def test_extra_names_are_nil
     assert_nil ta.cc
   end
 
-  def test_args_can_reference_env_values
+  def test_args_do_not_reference_env_values
     ta = Rake::TaskArguments.new(["aa"], [1])
     ENV['rev'] = "1.2"
     ENV['VER'] = "2.3"
-    assert_equal "1.2", ta.rev
-    assert_equal "2.3", ta.ver
+    assert_nil ta.rev
+    assert_nil ta.ver
   end
 
   def test_creating_new_argument_scopes