adds support for the new login procedure #93
Conversation
Gezzo42
commented
Jan 9, 2024
Gezzo42
commented
- FRITZ!OS 7.24 and later supports new response generation using PBKDF2
- technical note: https://avm.de/fileadmin/user_upload/Global/Service/Schnittstellen/AVM%20Technical%20Note%20-%20Session%20ID_EN%20-%20Nov2020.pdf
- adds test for login using new variant
|
One check failed, because setuptools is used, according to pyca/cryptography#6411 |
|
Hi, thanks for providing this PR. Unfortunatly I do not know how to solve this issue. One possible workaround could be to disable the pypy support or check if a newer version of pypy (e.g. 3.10) changes the behavior. |
I did a test and your changes seems to build with pypy3.9 and pypy3.10. So please change the used version in .github/workflows/test.yml. While on it please meld/rebase your first 3 commits into one. |
* FRITZ!OS 7.24 and later supports new response generation using PBKDF2 * technical note: https://avm.de/fileadmin/user_upload/Global/Service/Schnittstellen/AVM%20Technical%20Note%20-%20Session%20ID_EN%20-%20Nov2020.pdf * adds test for login using new variant * updates to pypy3.9 due to build problems with pypy3.7
|
thanks |
|
may this break for older Fritz!Box? |
As I understand this should have a fallback to old login mechanism: 1c8d5c1#diff-2739f308d4808e84f7bc38e336077eaaf3c76dbe979f853522a499c66d872391R127 |
|
ah ok 👍 |
Correct point. It should work. I could not test it, because my Fritz!Box firmware is newer. But the old test for it is still active and working correctly. |
|
Thanks for merging :-)! |
