forked from numenta/nupic.core-legacy
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Connections segment pruning #601
Merged
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
c672f49
Connections::adaptSegment fix segment pruning
breznak 3f4999c
SP & TM use synapse & segment pruning from Connections
breznak 1c3a684
TM.punishPredictedColumn_() is a private method of TM
breznak c47b7a4
TM:activatePredictedColumns() moved from static
breznak 9ce19f9
TM::burstColumn() made private from static
breznak d3ba477
TM:growSynapses() made private from static
breznak 4be092b
Connections:destroySynapse fixup, use find
breznak 6f535c4
fix deterministic test results
breznak b6d04bb
reintroduce lower_bound w deterministic ordering
breznak b7fa36e
Merge branch 'master_community' into fix_conn_stimulusThreshold
breznak 4a571bb
Merge branch 'master_community' into fix_conn_stimulusThreshold
breznak 36608e5
cleanup createSegment
breznak f35daf7
assert
breznak 97ec6bf
Connections: remove vector destroySegments_
breznak 24b39be
Connections: fix crash in destroySynapse
breznak 0b53cf7
Connections: removed vector destroyedSynapses_
breznak f2e16ef
Merge branch 'master_community' into fix_conn_stimulusThreshold
breznak 2d1bd5a
fix exact output results from CI
breznak a400325
SP cannot call adaptSegment with pruning,
breznak aaa6385
Merge branch 'master_community' into fix_conn_stimulusThreshold
breznak c3e0cbb
SP: WIP enable segment pruning
breznak 9691459
Connections: cosmetic cleanup synapsesForSegment()
breznak 3d9d60d
Merge branch 'master_community' into fix_conn_stimulusThreshold
breznak 03e2fc5
Merge branch 'conn_createSyn2' into fix_conn_stimulusThreshold
breznak b91144d
fix bug in Conn.pruneLRUSegment_()
breznak 46e4ca5
SP: enable segment pruning for Conn.adaptSegment
breznak b58258c
COnn revert to lower_bound with explicit ordering
breznak 6bc3dc7
Connections: add test for destroySynapse
breznak bcefa8c
COnnections: add test for createSynapse
breznak 56b6a1f
Connections adaptSegment: improve py binding
breznak 21cd185
COnnections: fix dataForSynapse() after destroyed
breznak 7463e5f
Connections: test for createSynapse
breznak 1d9518b
COnnections.createSynapse : update exiting if higher permanence
breznak b0d1338
revert changes to SP and deterministic results
breznak 1de0631
bump test values for new changes
breznak 038a292
COnnections: add couple of noexcept
breznak 540f3c4
Connections tests for createSegment()
breznak bf7ee11
COnnections: test for destroySegment()
breznak 3c67eb5
tests advanced_connections.py drop duplicit tests
breznak ffb8ee8
Connections dataForSegment throws if segment removed
breznak 690047c
Merge branch 'master_community' into fix_conn_stimulusThreshold
breznak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
COnnections.createSynapse : update exiting if higher permanence
if the new permanence is higher that the permanence of the old (same) synapse, update to the higher value.
- Loading branch information
commit 1d9518b2fe318bdca1f6c0a9a93263c6778ae148
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documented and changed the default strategy for
createSynapse()
if such synapse already exists. All four alternatives discussed above,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...impact is not really seen in our unit-tests as none trigger this "duplicit synapse created" branch.