-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-based parsing for continuous updates #86
Open
jefffohl
wants to merge
27
commits into
htm-community:master
Choose a base branch
from
jefffohl:issue78
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld code in client.
…em. Not working quite yet, but this is a good save point.
…and some would not. I am not sure why, but sending all of the lines together as a long string works, whereas sending individual lines to the parser one at a time only seemed to work sometimes.
…e browser. Though, I think the architecture is wrong. Right now, the client is handling the playing - it should be the server.
…e. Client just needs to signal to the server when to play, when to pause.
…e wave, and also improves the threshold highlighting
@jefffohl I'm going to test and merge this brange, as it's a lot of work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@breznak I am making a pull request for this solution to the continuous updates issue. Adding this functionality required a dramatic rewrite, which includes:
In this branch I also modified some things. Specifically:
Please let me know your thoughts. I would appreciate your feedback before I merge, since there are such extensive changes.