Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-based parsing for continuous updates #86

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

jefffohl
Copy link
Member

@breznak I am making a pull request for this solution to the continuous updates issue. Adding this functionality required a dramatic rewrite, which includes:

  • Building a server for the reading of local (and in the future, remote) files.
  • Implemented socket.io as the primary method for exchanging data between the server and the client. This allows us to push data from the server to the client as new data comes in.

In this branch I also modified some things. Specifically:

  • The function used to highlight thresholds in the graph. It is now more accurate.
  • The notification system is improved.
  • The layout has been improved.

Please let me know your thoughts. I would appreciate your feedback before I merge, since there are such extensive changes.

…em. Not working quite yet, but this is a good save point.
…and some would not. I am not sure why, but sending all of the lines together as a long string works, whereas sending individual lines to the parser one at a time only seemed to work sometimes.
…e browser. Though, I think the architecture is wrong. Right now, the client is handling the playing - it should be the server.
…e. Client just needs to signal to the server when to play, when to pause.
…e wave, and also improves the threshold highlighting
@breznak
Copy link
Member

breznak commented Oct 14, 2016

@jefffohl I'm going to test and merge this brange, as it's a lot of work.
I'd like to revive the project, eg. by using it in breznak/openDS-oss#28 and spreading more its usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants