Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate property fallback lookup (no implicit this) #334

Merged
merged 2 commits into from
Dec 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/components/vertical-collection/template.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{#each virtualComponents key="id" as |virtualComponent| ~}}
{{#each this.virtualComponents key="id" as |virtualComponent| ~}}
{{~unbound virtualComponent.upperBound~}}
{{~#if virtualComponent.isOccludedContent ~}}
{{{unbound virtualComponent.element}}}
Expand All @@ -8,6 +8,6 @@
{{~unbound virtualComponent.lowerBound~}}
{{~/each}}

{{#if shouldYieldToInverse}}
{{#if this.shouldYieldToInverse}}
{{yield to="inverse"}}
{{/if}}
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<div class="table-wrapper dark">
{{#vertical-collection model
{{#vertical-collection this.model
estimateHeight=50
bufferSize=5

as |item index|}}
{{number-slide item=item itemIndex=index}}
{{/vertical-collection}}
Expand Down
4 changes: 2 additions & 2 deletions tests/dummy/app/routes/components/number-slide/template.hbs
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<div class="number">{{if prefixed number item.prefixed}}</div>
<div class="index">({{itemIndex}})</div>
<div class="number">{{if this.prefixed this.number this.item.prefixed}}</div>
<div class="index">({{this.itemIndex}})</div>
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<td class="dbname">
{{db.id}}
{{@db.id}}
</td>
<td class="query-count">
<span class="{{countClassName}}">
{{queries.length}}
<span class="{{this.countClassName}}">
{{this.queries.length}}
</span>
</td>
{{#each topFiveQueries key="@index" as |query|}}
{{#each this.topFiveQueries key="@index" as |query|}}
<td>{{query.elapsed}}</td>
<div class="popover bottom">
<div class="popover-content">{{query.query}}</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{{!- BEGIN-SNIPPET flexible-layout-example }}
<div class="table-wrapper dark">
{{#vertical-collection
model.numbers
@model.numbers
estimateHeight=270
firstReached=(action "loadAbove")
lastReached=(action "loadBelow")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{{!- BEGIN-SNIPPET infinite-scroll-example }}
<div class="table-wrapper dark">
{{#vertical-collection
model.numbers
@model.numbers
estimateHeight=90
staticHeight=true
bufferSize=5
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/app/routes/examples/reduce-debug/template.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<h3>Demo</h3>
<div class="table-wrapper dark">
{{#vertical-collection
items=model.filtered
items=@model.filtered
defaultHeight=270
useContentProxy=false
as |item index|
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="col-sm-7">
{{!- BEGIN-SNIPPET scrollable-body-example }}
{{#vertical-collection
model.numbers
@model.numbers
estimateHeight=40
containerSelector="body" as |item index|
}}
Expand Down