Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests/testdata (for <svg><p> in innerHTML) #531

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Update tests/testdata (for <svg><p> in innerHTML) #531

merged 2 commits into from
Mar 29, 2021

Conversation

zcorpan
Copy link
Contributor

@zcorpan zcorpan commented Mar 2, 2021

I didn't manage to get py.test working, so don't know if/how test expectations (in .pytest.expect) need changing.

cc @jgraham @gsnedders @annevk

@zcorpan
Copy link
Contributor Author

zcorpan commented Mar 2, 2021

I got py.test working now. I needed todo pip install pytest-expect...

@zcorpan
Copy link
Contributor Author

zcorpan commented Mar 2, 2021

OK, py.test passes now.

This was referenced Mar 2, 2021
Merged
Open
@annevk
Copy link
Contributor

annevk commented Mar 3, 2021

This seems fine, but I have no power here.

@zcorpan
Copy link
Contributor Author

zcorpan commented Mar 29, 2021

@jgraham ping

@zcorpan zcorpan mentioned this pull request Mar 29, 2021
Merged
3 tasks
@jgraham jgraham merged commit ad3bde7 into html5lib:master Mar 29, 2021
@zcorpan zcorpan deleted the bocoup/sync-testdata-svg-p-innerhtml branch March 29, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcorpan @annevk @jgraham