Merge pull request #13 from shootaroo/rule-disable

Disable rule at false value
htmlhint · Jun 14, 2014 · 52eac81 · 52eac81
2 parents 3bfaeaf + d420c14
commit 52eac81
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -37,8 +37,8 @@ var HTMLHint = (function (undefined) {
             rule;
         for (var id in ruleset){
             rule = rules[id];
-            if (rule !== undefined){
-                rule.init(parser, reporter, ruleset[id]);
+            if (rule !== undefined && ruleset[id] !== false){
+              rule.init(parser, reporter, ruleset[id]);
             }
         }
 

diff --git a/test/rules/attr-lowercase.spec.js b/test/rules/attr-lowercase.spec.js
@@ -29,4 +29,10 @@ describe('Rules: '+ruldId, function(){
         expect(messages.length).to.be(0);
     });
 
+    it('Set is false not result in an error', function(){
+        var code = '<p TEST="abc">';
+        ruleOptions[ruldId] = false;
+        var messages = HTMLHint.verify(code, ruleOptions);
+        expect(messages.length).to.be(0);
+    });
 });