Parenthesis and asterisk trigger parsing errors

[floo51]

Angular 2 introduces a new syntax for attributes which can lead to this :

<li *ng-for="#item of collection">
  <button (click)="action(item)">Do something</button>
</li>

This is plain valid HTML but it triggers those 2 errors :

• Special characters must be escaped
• Tag must be paired

[yaniswang]

HTMLHint only support HTML code, your angular code is template, no supported.

[saeidzebardast]

Same problem in Polymer when using $ in attribute name:

• ([</div>] Tag must pair)

<div id$="[[myId]]">
  <content></content>
</div>

[floo51]

Taken from the W3C HTML specification :

Attribute names must consist of one or more characters other than the space characters, U+0000 NULL, """, "'", ">", "/", "=", the control characters, and any characters that are not defined by Unicode.

Following this rule, the code <div my*attribute="" *ng-for="" id$=""></div> is totally valid.

[szabyg]

+1 We would need this as well.
Any implementation hints, ideas, workaround?

[the-ult]

+1

[david-gang]

Hi @yaniswang ,

The issue is with the regular expression at: https://github.com/yaniswang/HTMLHint/blob/master/src/htmlparser.js#L36-L38

If we could make them unicode aware, we would solve the issue.

There are already projects working with regular expression and unicode like https://github.com/slevithan/xregexp

What do you think about this approach?

[mochtu]

+1

[Zorgatone]

+1:+1:

[felixfbecker]

This is a serious bug... In a nutshell HTMLHint throwing errors on valid HTML. Can we please get a fix for this?

[Zorgatone]

I totally agree @felixfbecker

[felixfbecker]

Instead of whitelisting characters here

/\s*([\w\-:]+)(?:\s*=\s*(?:(")([^"]*)"|(')([^']*)'|([^\s"'>]*)))?/

it should use an inverted character class that includes anything but "'>/=, NULL and whitespace:

/\s*([^"'>/=\0\s]+)(?:\s*=\s*(?:(")([^"]*)"|(')([^']*)'|([^\s"'>]*)))?/

Element tag names are not affected (see W3C)

[felixfbecker]

Made a PR

[yaniswang]

Fixed now: b6a4d1a

[aaawhz]

加上jsp语法吧， 我们很多页面都是用jsp写的。。。

[Zorgatone]

So is this really parsing HTML using Regular Expressions?