Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from colors to chalk #432

Closed
Shinigami92 opened this issue May 31, 2020 · 1 comment · Fixed by #433
Closed

Switch from colors to chalk #432

Shinigami92 opened this issue May 31, 2020 · 1 comment · Fixed by #433
Assignees
@Shinigami92

Comments

@Shinigami92
Copy link
Contributor

Is your feature request related to a problem?

I looked at the top repos and their support
chalk seems to be the winner here

https://www.npmtrends.com/chalk-vs-cli-color-vs-colors

Describe the solution you'd like

  • Remove dependency colors
  • Add dependency chalk
  • Change related code to use chalk instead of colors

Additional contect

https://github.com/chalk/chalk#readme
@Shinigami92 Shinigami92 self-assigned this May 31, 2020
Shinigami92 pushed a commit that referenced this issue May 31, 2020
chore: remove colors dependency
5e564fb 
BREAKING CHANGE: Colors will be displayed with chalk

fix #432
Shinigami92 pushed a commit that referenced this issue May 31, 2020
feat: add chalk dependency
95f4626 
BREAKING CHANGE: Replace colors with chalk

fix #432
@thedaviddias thedaviddias linked a pull request May 31, 2020 that will close this issue
feat: use chalk instead of colors #433
Merged
@thedaviddias
Copy link
Member

🎉 This issue has been resolved in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use chalk instead of colors htmlhint/HTMLHint
2 participants
@thedaviddias @Shinigami92