-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Bump minimum supported Node.js version to v16 #1369
base: master
Are you sure you want to change the base?
Conversation
e389029
to
f6ece36
Compare
f6ece36
to
5442446
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
- Coverage 99.07% 97.94% -1.13%
==========================================
Files 2 2
Lines 1627 1658 +31
Branches 332 341 +9
==========================================
+ Hits 1612 1624 +12
- Misses 15 34 +19
Continue to review full report in Codecov by Sentry.
|
Short description of what this resolves:
Node.js v16 just hit EOL a few months ago. I saw that Node.js v16 was still in CI, which is even older, so I didn't make v18 the minimum since it seems this repository lags behind.
Let me know if I should make v18 the minimum - that's one less upgrade in the future and less worry about using dependencies that could set their minimums to v18.
Proposed changes:
"engines"
configuration (v16 is already used in.nvmrc
)tsconfig.json
to use v16 presetmodule
/moduleResolution
), some updates to the imports had to be madetsconfig.json
options of recent TypeScript version