Fix config only being found below the working dir #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glob used to find files to lint was also being used to walk up to find configuration files. Given a file layout like: foo/ .htmlhintrc bar/ test.html htmlhint would not pick up the configuration if foo/bar/ was the working directory, however it would if foo/ was the working directory.
thedaviddias
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob used to find files to lint was also being used to walk up to
find configuration files. Given a file layout like:
htmlhint would not pick up the configuration if
foo/bar/was the workingdirectory, however it would if
foo/was the working directory.