Adding support for a white list of elements that can be lower case. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling the rule instead of using a boolean, use an array with the attributes (camelCased) that you want to ignore
```json
{
"tagname-lowercase": ["clipPath"]
}
```
2 similar comments
|
@thedaviddias imho this branch should also be merged asap. Documentation should be added but we can create a new issue for that. |
|
Ok @hacknug, I'm going to review and accept it. Thanks! |
thedaviddias
added
enhancement
|
This will solve #263 👍 But @aaronkahlhamer can you please add one or more tests to cover this case? Thank you for your contribution |
Codecov Report
@@ Coverage Diff @@
## develop #188 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 1 1
======================================
Hits 1 1Continue to review full report at Codecov.
|
thedaviddias
pushed a commit
that referenced
this pull request
Sep 3, 2018
… be lower case. (#188) When enabling the rule instead of using a boolean, use an array with the attributes (camelCased) that you want to ignore ```json { "tagname-lowercase": ["clipPath"] } ```
thedaviddias
pushed a commit
that referenced
this pull request
Sep 3, 2018
… be lower case. (#188) When enabling the rule instead of using a boolean, use an array with the attributes (camelCased) that you want to ignore ```json { "tagname-lowercase": ["clipPath"] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling the rule instead of using a boolean, use an array with the attributes (camelCased) that you want to ignore
{ "tagname-lowercase": ["clipPath"] }