Fix npm warning #191
Merged
Fix npm warning #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when installing HTMLHint, npm is warning about a deprecated version of minimatch. This updates the jshint dependency which currently uses and old version of minimatch.
|
@yaniswang *ping* |
|
@yaniswang would you mind publishing this to NPM? We'd like to include htmlhint in one of the default builds of Sails, and this deprecation message is all that's stopping that from happening. Great work btw! |
|
OK, for purposes of time, I went ahead and published a fork. Also removed a couple of other annoying deprecation messages: Before: After: All dependency semver ranges are still pinned 👍 I hope we can switch back to using this package in the future! In the mean time, our fork is published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when installing HTMLHint, npm is warning about a deprecated version of minimatch.
This updates the jshint dependency which is the culprit of the warning.