fix: update the check for root htmlhintrc #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedaviddias
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #285 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 1 1
======================================
Hits 1 1Continue to review full report at Codecov.
|
thedaviddias
changed the title
Shinigami92
approved these changes
Sep 1, 2018
thedaviddias
added a commit
that referenced
this pull request
Sep 3, 2018
**Fixes**: #163 and #181 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: The fix was originally suggested by @phaux and make HTMLHint checking the root for the config file. #### Proposed changes: - Change the tmpConfigFilve variable. - Force the console to "break" if base is not found.
thedaviddias
added a commit
that referenced
this pull request
Sep 3, 2018
**Fixes**: #163 and #181 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: The fix was originally suggested by @phaux and make HTMLHint checking the root for the config file. #### Proposed changes: - Change the tmpConfigFilve variable. - Force the console to "break" if base is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #163 and #181
Short description of what this resolves:
The fix was originally suggested by @phaux and make HTMLHint checking the root for the config file.
Proposed changes: