-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(htmlhint) feature/add commitizen package, husky and prettier #287
Conversation
101872c
to
b65b168
Compare
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 1 1
======================================
Hits 1 1 Continue to review full report at Codecov.
|
) * style(htmlhint): update name changes to changelog * feat(htmlhint): add husky, lint-staged, commitizen and commilint solve #258 * chore(htmlhint): remove lint-staged and move pretty-quick to precommit * fix(htmlhint): remove grunt-cli and npm test * chore(htmlhint): update package-lock
"analysis", | ||
"javascript" | ||
], | ||
"author": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the "author" and "contributors" :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see why, the list of contributors is given by Github easily and everyone can see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because you can see the package.json in node_modules
(It's only for author and main contributors)
) * style(htmlhint): update name changes to changelog * feat(htmlhint): add husky, lint-staged, commitizen and commilint solve #258 * chore(htmlhint): remove lint-staged and move pretty-quick to precommit * fix(htmlhint): remove grunt-cli and npm test * chore(htmlhint): update package-lock
Fixes: #255 & #258
Short description of what this resolves:
Add precommit hooks to ensure the uniformity of commit messages and prettier to format the code automatically.
Proposed changes: