chore(htmlhint) feature/add commitizen package, husky and prettier #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
thedaviddias
force-pushed
the
feature/add-commitizen-package
branch
from
101872c
to
b65b168
Compare
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 1 1
======================================
Hits 1 1Continue to review full report at Codecov.
|
thedaviddias
added a commit
that referenced
this pull request
Sep 3, 2018
) * style(htmlhint): update name changes to changelog * feat(htmlhint): add husky, lint-staged, commitizen and commilint solve #258 * chore(htmlhint): remove lint-staged and move pretty-quick to precommit * fix(htmlhint): remove grunt-cli and npm test * chore(htmlhint): update package-lock
Shinigami92
reviewed
Sep 3, 2018
| "analysis", | ||
| "javascript" | ||
| ], | ||
| "author": { |
There was a problem hiding this comment.
I'm missing the "author" and "contributors" :(
There was a problem hiding this comment.
Don't see why, the list of contributors is given by Github easily and everyone can see it.
There was a problem hiding this comment.
Because you can see the package.json in node_modules
(It's only for author and main contributors)
thedaviddias
added a commit
that referenced
this pull request
Sep 3, 2018
) * style(htmlhint): update name changes to changelog * feat(htmlhint): add husky, lint-staged, commitizen and commilint solve #258 * chore(htmlhint): remove lint-staged and move pretty-quick to precommit * fix(htmlhint): remove grunt-cli and npm test * chore(htmlhint): update package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #255 & #258
Short description of what this resolves:
Add precommit hooks to ensure the uniformity of commit messages and prettier to format the code automatically.
Proposed changes: