Add attr no unnecessary whitespace #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Fixes**: #325 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: In the original pull request some of the test cases were missing. Added --recursive option for mocha to check for all individual rules.
* 0.10.3 * feat(htmlhint): add new rule for whitespace in attributes (#310) * fix(htmlhint): removed unnecessary code (#310) * 0.11.0 * Revert "Merge branch 'develop' into attr-whitespace" This reverts commit 35988c1, reversing changes made to 981cca7. * Revert "Revert "Merge branch 'develop' into attr-whitespace"" This reverts commit cfa794d. * chore(htmlhint): rebuilt package.json * chore(htmlhint): updated rule to use ES6 * 0.10.3 * 0.11.0 * fix(htmlhint): made change to test cases and index.js
This is a new formatter which logs error messages in html format on console as well as it will generate a report file in html format **Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: New formatter #### Proposed changes: New formatter ## - - 👍 Thank you!
…331) **Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: Added rule to check for special characters in tag name. See (#146) #### Proposed changes: ## - - 👍 Thank you!
Based on #238 Add ability to pass regexp in `.htmlhintrc` file for matching attributes value. Example: ```js ... "id-class-value": { "regId": "^[a-z\\d]+([-_]+[a-z\\d]+)*$", "message": "The id and class attribute values must be in lowercase and split by dash or underscore" }, ... ``` Problem was in parsing config file by `JSON.parse`. We can not correct pass `regexp` into json schema. Only `string`. And this `string` after parsing is `string` too. I just check input data. If it is not regexp then create `new RegExp` instance from input string. **Fixes**: # 🚨 Please review the [guidelines for contributing](CONTRIBUTING.md) and our [code of conduct](../CODE_OF_CONDUCT.md) to this repository. 🚨 **Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:** - [ ] Check the commit's or even all commits' message styles matches our requested structure. - [ ] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: #### Proposed changes: ## - - 👍 Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #220
🚨 Please review the guidelines for contributing and our code of conduct to this repository. 🚨
Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR: