Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clenaup non-functional typos #727

Merged
merged 1 commit into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<a href="https://www.npmjs.com/package/htmlhint">
<img src="https://img.shields.io/npm/dm/htmlhint.svg" alt="NPM count">
</a>
<img src="https://badgen.net/badge/license/MIT/green" alt="MIT Licence" />
<img src="https://badgen.net/badge/license/MIT/green" alt="MIT License" />
<a href="https://discord.gg/nJ6J9CP">
<img src="https://img.shields.io/badge/chat-on%20discord-7289da.svg" alt="Chat">
</a>
Expand Down
2 changes: 1 addition & 1 deletion docs/user-guide/rules/input-requires-label.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: input-requires-label
keywords:
- input
- label
- accessiblity
- accessibility
---

All [ input ] tags must have a corresponding [ label ] tag.
Expand Down
2 changes: 1 addition & 1 deletion docs/user-guide/rules/src-not-empty.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ title: src-not-empty

Src of img(script, link) must set value.

Emtpy of src will visit current page twice.
Empty of src will visit current page twice.

Level: `error`

Expand Down
6 changes: 3 additions & 3 deletions src/cli/htmlhint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ function hintTargets(
})
}

// load custom rles
// load custom rules
function loadCustomRules(rulesdir: string) {
rulesdir = rulesdir.replace(/\\/g, '/')
if (existsSync(rulesdir)) {
Expand Down Expand Up @@ -215,7 +215,7 @@ function hintAllFiles(
formatter: Formatter
ruleset?: Ruleset
},
onFinised: (result: {
onFinished: (result: {
targetFileCount: number
targetHintFileCount: number
targetHintCount: number
Expand Down Expand Up @@ -292,7 +292,7 @@ function hintAllFiles(

function checkAllHinted() {
if (isWalkDone && isHintDone) {
onFinised({
onFinished({
targetFileCount: targetFileCount,
targetHintFileCount: targetHintFileCount,
targetHintCount: targetHintCount,
Expand Down
2 changes: 1 addition & 1 deletion src/core/rules/tags-check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default {
redundantAttrs.forEach((attrName) => {
if (attrs.some((attr) => attr.name === attrName)) {
reporter.error(
`The attr '${attrName}' is redundant for <${tagName}> and should be ommited.`,
`The attr '${attrName}' is redundant for <${tagName}> and should be omitted.`,
event.line,
col,
this,
Expand Down
2 changes: 1 addition & 1 deletion test/core.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('Core', () => {
expect(messages.length).to.be(0)
})

it('Show formated result should not result in an error', () => {
it('Show formatted result should not result in an error', () => {
const code =
'tttttttttttttttttttttttttttttttttttt<div>中文<img src="test.gif" />tttttttttttttttttttttttttttttttttttttttttttttt'
const messages = HTMLHint.verify(code, {
Expand Down
20 changes: 10 additions & 10 deletions test/rules/alt-require.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'alt-require'
const ruleId = 'alt-require'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Img tag have empty alt attribute should not result in an error', () => {
const code = '<img width="200" height="300" alt="">'
const messages = HTMLHint.verify(code, ruleOptions)
Expand All @@ -24,7 +24,7 @@ describe(`Rules: ${ruldId}`, () => {
const code = '<img width="200" height="300">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(5)
expect(messages[0].type).to.be('warning')
Expand All @@ -47,7 +47,7 @@ describe(`Rules: ${ruldId}`, () => {
const code = '<area href="#test">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(6)
expect(messages[0].type).to.be('warning')
Expand All @@ -57,13 +57,13 @@ describe(`Rules: ${ruldId}`, () => {
const code = '<area href="#test" alt="">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(6)
expect(messages[0].type).to.be('warning')
})

it('Area[href] tag have non emtpy alt attribute should not result in an error', () => {
it('Area[href] tag have non empty alt attribute should not result in an error', () => {
const code = '<area href="#test" alt="test">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(0)
Expand All @@ -85,7 +85,7 @@ describe(`Rules: ${ruldId}`, () => {
const code = '<input type="image">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(7)
expect(messages[0].type).to.be('warning')
Expand All @@ -95,13 +95,13 @@ describe(`Rules: ${ruldId}`, () => {
const code = '<input type="image" alt="">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(7)
expect(messages[0].type).to.be('warning')
})

it('Input[type="image"] tag have non emtpy alt attribute should not result in an error', () => {
it('Input[type="image"] tag have non empty alt attribute should not result in an error', () => {
const code = '<input type="image" alt="test">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(0)
Expand Down
20 changes: 10 additions & 10 deletions test/rules/attr-lowercase.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,27 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-lowercase'
const ruleId = 'attr-lowercase'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Not all lowercase attr should result in an error', () => {
let code = '<p TEST="abc">'
let messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(3)

code = '<p id=""\r\n TEST1="abc" TEST2="abc">'
messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(2)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(2)
expect(messages[0].col).to.be(1)
expect(messages[1].rule.id).to.be(ruldId)
expect(messages[1].rule.id).to.be(ruleId)
expect(messages[1].line).to.be(2)
expect(messages[1].col).to.be(13)
})
Expand All @@ -35,28 +35,28 @@ describe(`Rules: ${ruldId}`, () => {

it('Set is false should not result in an error', () => {
const code = '<p TEST="abc">'
ruleOptions[ruldId] = false
ruleOptions[ruleId] = false
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(0)
})

it('Set to array list should not result in an error', () => {
const code = '<p testBox="abc" tttAAA="ccc">'
ruleOptions[ruldId] = ['testBox', 'tttAAA']
ruleOptions[ruleId] = ['testBox', 'tttAAA']
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(0)
})

it('Set to array list with RegExp should not result in an error', () => {
const code = '<p testBox="abc" bind:tapTop="ccc">'
ruleOptions[ruldId] = ['testBox', /bind:.*/]
ruleOptions[ruleId] = ['testBox', /bind:.*/]
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(0)
})

it('Set to array list with regex string should not result in an error', () => {
const code = '<p testBox="abc" [ngFor]="ccc">'
ruleOptions[ruldId] = ['testBox', '/\\[.*\\]/']
ruleOptions[ruleId] = ['testBox', '/\\[.*\\]/']
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(0)
})
Expand Down
8 changes: 4 additions & 4 deletions test/rules/attr-no-duplication.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-no-duplication'
const ruleId = 'attr-no-duplication'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Attribute name been duplication should result in an error', () => {
const code = '<a href="a" href="b">bbb</a>'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(12)
})
Expand Down
8 changes: 4 additions & 4 deletions test/rules/attr-no-unnecessary-whitespace.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-no-unnecessary-whitespace'
const ruleId = 'attr-no-unnecessary-whitespace'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Attribute with spaces should result in an error', () => {
const codes = [
'<div title = "a" />',
Expand All @@ -17,7 +17,7 @@ describe(`Rules: ${ruldId}`, () => {
for (let i = 0; i < codes.length; i++) {
const messages = HTMLHint.verify(codes[i], ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(5)
}
Expand Down
2 changes: 1 addition & 1 deletion test/rules/attr-sort.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ruleOptions[ruleId] = true

describe(`Rules: ${ruleId}`, () => {
it('Attribute unsorted tags must result in an error', () => {
const code = '<div id="test" class="class" title="tite"></div>'
const code = '<div id="test" class="class" title="title"></div>'

const messages = HTMLHint.verify(code, ruleOptions)

Expand Down
8 changes: 4 additions & 4 deletions test/rules/attr-unsafe-chars.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-unsafe-chars'
const ruleId = 'attr-unsafe-chars'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Attribute value have unsafe chars should result in an error', () => {
const code =
'<a href="https://vimeo.com/album/1951235/video/56931059‎">Sud Web 2012</a>'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(3)
expect(messages[0].type).to.be('warning')
Expand Down
12 changes: 6 additions & 6 deletions test/rules/attr-value-double-quotes.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-value-double-quotes'
const ruleId = 'attr-value-double-quotes'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Attribute value closed by single quotes should result in an error', () => {
const code = "<a href='abc' title=abc style=''>"
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(3)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(3)
expect(messages[1].rule.id).to.be(ruldId)
expect(messages[1].rule.id).to.be(ruleId)
expect(messages[1].line).to.be(1)
expect(messages[1].col).to.be(14)
expect(messages[2].rule.id).to.be(ruldId)
expect(messages[2].rule.id).to.be(ruleId)
expect(messages[2].line).to.be(1)
expect(messages[2].col).to.be(24)
})
Expand Down
8 changes: 4 additions & 4 deletions test/rules/attr-value-not-empty.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-value-not-empty'
const ruleId = 'attr-value-not-empty'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Attribute value have no value should result in an error', () => {
const code = '<input disabled>'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(1)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(7)
expect(messages[0].type).to.be('warning')
Expand Down
12 changes: 6 additions & 6 deletions test/rules/attr-value-single-quotes.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@ const expect = require('expect.js')

const HTMLHint = require('../../dist/htmlhint.js').HTMLHint

const ruldId = 'attr-value-single-quotes'
const ruleId = 'attr-value-single-quotes'
const ruleOptions = {}

ruleOptions[ruldId] = true
ruleOptions[ruleId] = true

describe(`Rules: ${ruldId}`, () => {
describe(`Rules: ${ruleId}`, () => {
it('Attribute value closed by double quotes should result in an error', () => {
const code = '<a href="abc" title=abc style="">'
const messages = HTMLHint.verify(code, ruleOptions)
expect(messages.length).to.be(3)
expect(messages[0].rule.id).to.be(ruldId)
expect(messages[0].rule.id).to.be(ruleId)
expect(messages[0].line).to.be(1)
expect(messages[0].col).to.be(3)
expect(messages[1].rule.id).to.be(ruldId)
expect(messages[1].rule.id).to.be(ruleId)
expect(messages[1].line).to.be(1)
expect(messages[1].col).to.be(14)
expect(messages[2].rule.id).to.be(ruldId)
expect(messages[2].rule.id).to.be(ruleId)
expect(messages[2].line).to.be(1)
expect(messages[2].col).to.be(24)
})
Expand Down
Loading