Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use Jest with Snapshots #823

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nschonni
Copy link
Contributor

Short description of what this resolves:

Just trying this one again to see if the random CI issues have resolved

Proposed changes:

@github-actions github-actions bot added cli Relates to HTMLHint's command-line interface core Relates to HTMLHint's core APIs and features dependencies Pull requests that update a dependency file test labels Dec 13, 2021
nschonni referenced this pull request in DavidAnson/markdownlint-cli2 Jan 5, 2022
@github-actions github-actions bot added the automation Changes done to the .github folder label Jan 5, 2022
@nschonni
Copy link
Contributor Author

nschonni commented Jan 5, 2022

Interesting. Forcing on the colour may have resolve some of the issues, but now I need to update that SVG test that was created after the orginal coversion

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #823 (e935dcc) into master (a629d0b) will decrease coverage by 31.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #823       +/-   ##
===========================================
- Coverage   98.58%   66.86%   -31.72%     
===========================================
  Files           1       48       +47     
  Lines         917     3217     +2300     
  Branches      191      360      +169     
===========================================
+ Hits          904     2151     +1247     
- Misses         13     1066     +1053     
Impacted Files Coverage Δ
src/core/rules/attr-lowercase.ts 100.00% <100.00%> (ø)
dist/htmlhint.js
src/core/rules/attr-no-duplication.ts 100.00% <0.00%> (ø)
src/core/rules/inline-style-disabled.ts 100.00% <0.00%> (ø)
src/core/rules/alt-require.ts 100.00% <0.00%> (ø)
src/core/rules/attr-value-not-empty.ts 100.00% <0.00%> (ø)
src/cli/formatters/compact.ts 0.00% <0.00%> (ø)
src/cli/htmlhint.ts 0.00% <0.00%> (ø)
src/core/rules/attr-no-unnecessary-whitespace.ts 100.00% <0.00%> (ø)
src/core/rules/attr-unsafe-chars.ts 100.00% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5844f3...e935dcc. Read the comment docs.

@stale

This comment was marked as outdated.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Mar 10, 2022
@stale stale bot closed this Mar 27, 2022
@nschonni nschonni reopened this Mar 27, 2022
@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Mar 27, 2022
@stale

This comment was marked as outdated.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label May 31, 2022
@nschonni nschonni removed the bot:stale Issue marked as stale because there was no activity label May 31, 2022
@nschonni nschonni added the keep-unstale The issue will not be marked as stale by the stale-bot label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Changes done to the .github folder cli Relates to HTMLHint's command-line interface core Relates to HTMLHint's core APIs and features dependencies Pull requests that update a dependency file keep-unstale The issue will not be marked as stale by the stale-bot test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant