-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display warning log message when it can not parse config #893
Conversation
Sorry but I would fix tests. |
52ca8c9
to
653dd66
Compare
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 2 2
Lines 1627 1627
Branches 291 291
=======================================
Hits 1573 1573
Misses 54 54 Continue to review full report at Codecov.
|
653dd66
to
f39ef04
Compare
Tests are fixed. Could you review it? |
@thedaviddias |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@thedaviddias you approved this so can it be merged ? |
Yes, it can. @is2ei Can you just fix the conflict? |
f39ef04
to
9169f02
Compare
9169f02
to
f16d78c
Compare
I fixed the conflict. |
fix #662
Short description of what this resolves:
This PR changes it to display a warning log message when it can not parse config.
Proposed changes:
Display warning log message