BSD platforms: Reject negative and zero KERN_FSCALE factors #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explorer09
commented
Aug 2, 2023
BenBE
added
enhancement
Explorer09
force-pushed
the
bsd-fscale-reject-zero
branch
3 times, most recently
from
03c517d
to
a1a8887
Compare
BenBE
added
OpenBSD 🐡
Explorer09
force-pushed
the
bsd-fscale-reject-zero
branch
from
a1a8887
to
94f0cf4
Compare
The "fscale" value, retrieved by sysctl() in BSD platforms, is used for computing CPU percentages of the processes. To prevent a division by zero, we should reject a zero "fscale" value. (A negative "fscale" value will not make sense either.) For DragonFlyBSD and FreeBSD, this would fall back to the hard-coded default scale. For NetBSD and OpenBSD, there is no hard-coded default value, so the zero or negative "fscale" is now a fatal error. Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Explorer09
force-pushed
the
bsd-fscale-reject-zero
branch
from
94f0cf4
to
81d19a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "fscale" value, retrieved by
sysctl()in BSD platforms, is used for computing CPU percentages of the processes. To prevent a division by zero, we should reject a zero "fscale" value. (A negative "fscale" value will not make sense either.)For DragonFlyBSD and FreeBSD, this would fall back to the hard-coded default scale.
For NetBSD and OpenBSD, there is no hard-coded default value, so the zero or negative "fscale" is now a fatal error.