Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the tests able to run on Node 12 #572

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Conversation

Xmader
Copy link
Contributor

@Xmader Xmader commented Nov 7, 2019

Please ensure that your pull request fulfills these requirements:

  • The pull request is being made against the master branch
  • Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request? (bug fix, enhancement, new feature,...)

make the tests run on Node 12

#569 (comment)

What changes did you make?

  • upgrade vows to 0.8.3
  • add cleanup after all the tests finish

Copy link
Member

@thornjad thornjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, nice and clean. It's nice to have an explicit tear-down for something like a server which would reasonably continue running.

@thornjad thornjad added this to the v0.12.0 milestone Nov 9, 2019
@thornjad thornjad merged commit 1755478 into http-party:master Nov 9, 2019
@Xmader
Copy link
Contributor Author

Xmader commented Nov 9, 2019

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants