Refactored the vows test to use "macro"s and catch additional errors #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad, and reduced code duplication.
…or tests related changes: * Every httpServer.createServer now has a vow to check for errors. Additionally, the server object is returned, instead of using the callbacks. This is because the server is an EventEmitter, and vows.js can capture the error correctly. * Documented respondsWithMessage function * Refactored one case of checking for a 404 with respondsWith(404, ...)
bramp
changed the title
2 tasks
|
I like the idea of this PR! However, #693 moved us off of vows, so there's some significant changes. If you'd like to see the same changes in the new tests, I'd love a new PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Enhancement
What changes did you make?
Refactored the vows tests to:
Provide some example code that this change will affect, if applicable:
N/A
Is there anything you'd like reviewers to focus on?
Please provide testing instructions, if applicable:
npm test