Feature/allow cross origin isolated #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSlowGrowth
force-pushed
the
feature/Allow-cross-origin-isolated
branch
from
0c7028c to
ef7b79b
Compare
|
Fixes #650 |
|
What is the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
new feature - enable cross origin isolation.
This is required to access
SharedArrayBufferamong other things. See here:What changes did you make?
--coicommandline argumentoptions.coiIs there anything you'd like reviewers to focus on?
The test: It fails on both of the two required headers. I'm not sure why that happens, manual testing looks good (Testpage using
SharedArrayBufferin Firefox fails without--coibut works fine with--coi). Looking for advice.options.coiandoptions.corsare mutually exclusive. I made the command line version fail. How could I make it fail when usinghttpServer.createServer(...)?