Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerization of http-server
Relevant issues
Closes #724
Contributor checklist
--help
outputmaster
branchMaintainer checklist
Maintainers will do the building, tagging and pushing docker images.
These instructions are only for maintainers to release a new version in docker hub;
Building and Tagging the Docker Image
docker build -t {your-username}/http-server:{new-version} -t {your-username}/http-server:latest .
in project root folder.This builds and tags the docker image with "latest" tag and also with the version you provide.
Pushing the Docker Image
docker push {your-username}/http-server:{new-version}
docker push {your-username}/http-server:latest
Note: I already have the http-server images built in docker hub in my own repository (which is tozlu/http-server), if you would like to maintain docker images in your own repository, please change README and the build/push scripts above to reflect your username for docker hub.