Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add the parameters to the parameters map if they have a name #31

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

gameldar
Copy link

Closes #29 by only adding named parameters to the parameter map

Description

If the capture has an empty string for a name then don't add it to the map

Motivation and Context

Closes #29
Note this is technically a breaking change as before you could actually query for the parameter with an empty string.

How Has This Been Tested?

Unit tests have been implemented to ensure the intended behaviour

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Nemo157 Nemo157 mentioned this pull request Aug 13, 2019
12 tasks
@gameldar gameldar force-pushed the 29-unnamed-parameters branch from e6370b1 to d51187c Compare August 13, 2019 14:10
@Nemo157 Nemo157 force-pushed the 29-unnamed-parameters branch from d51187c to b42a055 Compare August 13, 2019 17:32
@Nemo157 Nemo157 merged commit 61e3b07 into http-rs:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unamed parameters end up in the parameter map
2 participants