Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #38

Merged
merged 8 commits into from
Aug 19, 2019
Merged

Cleanup #38

merged 8 commits into from
Aug 19, 2019

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Aug 17, 2019 •
edited
Loading

Description

  • Move tests to submodules so they aren't compiled in normal build
  • Migrate to edition 2018
  • Fix maybe useful clippy pedantic lints (without enabling them always as they are potentially buggy)
  • Add benchmarks to CI to avoid accidental breakage

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Nemo157 Nemo157 mentioned this pull request Aug 17, 2019
Open
12 tasks
gameldar
gameldar approved these changes Aug 19, 2019
View reviewed changes
Copy link

@gameldar gameldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

src/nfa.rs
} else if val > 63 {
Ascii(u64::MAX ^ (1 << (val - 64)), u64::MAX, true)
Ascii(u64::max_value() ^ (1 << (val - 64)), u64::max_value(), true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering - so I learn the difference here - is there a reason for switching from using the constant to the method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It avoids having to import the std::u64 module, and there is a plan to deprecate that module and replace it with associated constants.

@Nemo157 Nemo157 merged commit f6b9eca into http-rs:master Aug 19, 2019
@Nemo157 Nemo157 deleted the cleanup branch August 19, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gameldar gameldar gameldar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @gameldar