-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crate: add hyper-client feature #234
Conversation
3eef819
to
f45eb79
Compare
I have discovered that this still doesn't work because |
- Makes HyperClient impl Clone and Default - Re-uses the internal hyper client for pooling and alloc efficiency - Adds HyperClient::from_client() - Always uses the HttpsConnector (has internal http fallback) Required for hyper-client in Surf: http-rs/surf#234
8329257
to
08ff108
Compare
This now only waiting for http-rs/http-client#45 |
08ff108
to
8cbd454
Compare
Edit: actually nightly broke: rust-lang/rust#77089 Hmm, CI is failing because something in async-std?
|
- Makes HyperClient impl Clone and Default - Re-uses the internal hyper client for pooling and alloc efficiency - Adds HyperClient::from_client() - Always uses the HttpsConnector (has internal http fallback) Required for hyper-client in Surf: http-rs/surf#234
Is this targeted for 2.0.0? |
No this can be in 2.1 |
Adds support for `http-client/hyper_client`, including global pooling for one-off surf methods.
8cbd454
to
1647770
Compare
|
Merging this, it's been open plenty long and there is little code here, all of which is behind a feature flag. |
Adds support for
http-client/hyper_client
, including global pooling for one-off surf methods.Also adjusts client configuration to fallback once again, starting with the highest specificity (wasm) and allowing e.g.
features = ["hyper-client"]
to override the default.