Implement Connection persistence per RFC 9112, Section 9.3 #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
commented
Oct 24, 2024
| @@ -83,6 +85,32 @@ private[blaze] trait Http1Stage[F[_]] { self: TailStage[ByteBuffer] => | |||
| true | |||
| } | |||
|
|
|||
| private[http4s] final def checkRequestCloseConnection(req: Request[F]): Boolean = { | |||
There was a problem hiding this comment.
I tried to fix the Boolean blindness, but it ripples to many places.
| @@ -67,6 +68,7 @@ private[blaze] trait Http1Stage[F[_]] { self: TailStage[ByteBuffer] => | |||
| protected def contentComplete(): Boolean | |||
|
|
|||
| /** Check Connection header and add applicable headers to response */ | |||
| @deprecated("Use checkRequestCloseConnection(Request) instead", "0.23.17") | |||
There was a problem hiding this comment.
Kept for binary compatibility, though we could do the MiMa dance.
| else "\r\n") | ||
| closeOnFinish match { | ||
| case true if respConn.isEmpty => | ||
| rr << "Connection: close\r\n\r\n" |
There was a problem hiding this comment.
This was a buried side effect in the old code.
|
LGTM. Maybe a bit off-topic for this PR, but when returning a |
|
Hell, I started from the wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are aggressively closing connections in the presence of
Connectionheaders composed exclusively of options other thankeep-aliveorclose. This is contrary to the RFC