Webmock broken by new HTTP::Response#initialize API

[tarcieri]

See f40fbda: Use opts hash for HTTP::Response.new

This seems like a good change. I think we should release with this new API and update Webmock accordingly.

cc @Connorhd @nerdrew @zanker

[zanker]

Sounds good. I'd like to see us do this in a way that's more backwards compatible but I'm not exactly sure if that's feasible.

[ixti]

Oh. I merged that and forgot to provide webmock adapter update. Will do that this weekend.

[ixti]

I don't see a way to make it backward compatible either. But I don't see worth in keeping API backward compatible - we just removed bunch of methods ;D we're braking bad already :D

[tarcieri]

Sidebar: if we do this for Response, should we do it for Request too?

https://github.com/httprb/http/blob/master/lib/http/request.rb#L67

[ixti]

Agree!

[tarcieri]

Ok, I just merged #278 which updates the Request API (thanks @ixti) so I guess that means we're going with a breaking API change here

[tarcieri]

I released 1.0.0.pre4 with the updated HTTP::Request API.

@ixti want to take a crack at fixing Webmock?

[ixti]

Yeah. Sure. Will prepare a PR for webmock today. Sure.

[ixti]

PR for webmock is: bblimke/webmock#554
Meanwhile, I think we should move webmock integration under http gem.
So that in WebMock there will be only one line left: require "http/webmock".

That will make webmock adapter always up to date with http API.

[tarcieri]

In theory this should be the last breaking change because the 1.0 API should be stable, so I'm not sure that matters?

Perhaps we should move it the next time we feel the need to change it.

[ixti]

Agree!