Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify socket closure #96

Closed
tarcieri opened this issue Mar 13, 2014 · 5 comments
Closed

Verify socket closure #96

tarcieri opened this issue Mar 13, 2014 · 5 comments
Assignees
Milestone

Comments

@tarcieri
Copy link
Member

We're punting on keepalive and connection pooling (#72) for 0.6. We should ensure that sockets are closed correctly request completes (i.e. that we implement Connection: close semantics correctly)

@tarcieri tarcieri added this to the v0.6 milestone Mar 13, 2014
@tarcieri
Copy link
Member Author

Can anyone still reproduce this problem?

@schmurfy you perhaps?

@tarcieri
Copy link
Member Author

I don't see #close getting called anywhere, so I'm going to go out on a limb and say this is still a problem

@schmurfy
Copy link

I will give it a try but I am not sure what caused the issue in the first place :/
The only condition I managed to isolate was the response from the server included:

Transfer-Encoding: chunked

I was also doing hundreds of requests in parallel using Celluloid::IO and I don't think each requests kept the connection open... The number of requests does not seems to change much, on the test server the issue was the same with half the load.

I am not sure how useful the informations are at least that's a start xD

@ixti ixti self-assigned this Mar 24, 2014
@tarcieri
Copy link
Member Author

It looks like we need to call @socket.close in #finish_response, however #finish_response isn't being called reliably

@ixti
Copy link
Member

ixti commented Mar 28, 2014

This was addressed in #115

@ixti ixti closed this as completed Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants