Extract HTTP::Connection ala Reel (WIP: DO NOT MERGE) #72
Conversation
| raise StateError, "can't read in the '#{@request_fsm.state}' request state" | ||
| end | ||
|
|
||
| @parser.readpartial(size) |
There was a problem hiding this comment.
this is where the EOFError stuff may occur, see #46
There was a problem hiding this comment.
Note that this @parser (HTTP::Response::Parser) is fairly different from the original. Also, this doesn't initiate I/O directly, rather the parser itself does.
This is a work-in-progress commit to structure the connection management and pipelining closer to what is presently used today in Reel. Much of the code is modified copypasta from Reel. I wish there were a more DRY abstraction for this sort of thing (reusing client/server parts of HTTP libraries) but if it exists it presently escapes me.
|
Would be nice if you could get the underlying socket as a real IO object, aka .to_io so you could IO.copy_stream it. Some JSON parsers also check if they have a IO object and .read or something similar on it, but only when it is a IO object(aka is_a?(IO), not one which exposes similar methods. |
|
@Asmod4n we could support a "hijack" API similar to Rack (and Reel) which lets the program take control of the socket. I wouldn't want to directly expose the socket without such an API, as it could end up unsafely shared between user code and the HTTP gem. |
|
What more needs to be done before this can be merged? |
|
This is pretty out-of-date now (the PR is over a year old!). Honestly I (or someone else) should just start over at this point... |
|
Closed by #184 |
This is a work-in-progress commit to structure the connection management and pipelining closer to what is presently used today in Reel.
Much of the code is modified copypasta from Reel. I wish there were a more DRY abstraction for this sort of thing (reusing client/server parts of HTTP libraries) but if it exists it presently escapes me.
As there seems to be a lot of interest in this library as of late, I'm posing my (still nowhere near complete) WIP work for some early review. I wish there were a better way to break this change apart into a series of smaller, more easily reviewable changes, but as this is full blown "catching up to Reel" I'm not sure how that's possible.
Comments strongly encouraged!