Fail upon invalid HTTP header field name #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.03%) when pulling 8b8cae1991164d1aa0a68d940625e9f552ee3080 on improvement/fail-on-invalid-header-name into 1d00907 on master. |
ixti
force-pushed
the
improvement/fail-on-invalid-header-name
branch
from
8b8cae1
to
bcda58f
Compare
|
One note on this: There is the traditional wisdom of "be liberal in what you accept and strict in what you send". That said, I'm not sure that "wisdom" makes sense if we care about security. Maybe we should start favoring correctness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallows to pass invalid header field names like:
"Foo Bar"(using spaces)" Foo-Bar"(leading and/or tailing spaces)"Foo:Bar"(using separator field)See http://tools.ietf.org/html/rfc7230#section-3.2 and specifically
field-namesyntax for details.