Add an extra set of state tracking for Timeout.timeout edge cases #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +103,11 @@ def verify_connection!(uri) | |||
| # lazily load the body as long as possible, and this mimics prior functionality. | |||
| elsif @connection && (!@connection.keep_alive? || @connection.expired?) | |||
| close | |||
|
|
|||
There was a problem hiding this comment.
Why do you add this extra line? :D
There was a problem hiding this comment.
I mean, can you try to avoid it? :D
There was a problem hiding this comment.
I find it makes it harder to read personally, but I don't really care either way.
|
Seems ugly but so does Timeout 😜 In absence of a fully asynchronous timeout scheme this seems ok to me. |
|
Yea it's not great unfortunately but such is life :( |
| @@ -93,11 +98,14 @@ def close | |||
| def verify_connection!(uri) | |||
| if default_options.persistent? && base_host(uri) != default_options.persistent | |||
| fail StateError, "Persistence is enabled for #{default_options.persistent}, but we got #{base_host(uri)}" | |||
|
|
|||
zanker
added a commit
that referenced
this pull request
Mar 30, 2015
Add an extra set of state tracking for Timeout.timeout edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoughts? This isn't strictly necessary, as the chance of this happening is very very small. It is still a chance though.
Normally,
Timeout.timeoutraises an exception and kills the block and everything is handy dandy. In rare situations, it will raise and then kill execution while therescueblock executes (see mperham/connection_pool#67 for more info).This adds an extra layer of protection, where if we run into that, we reset the connection anyway.