Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we catch WaitWritable for SSL #199

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Conversation

zanker
Copy link
Contributor

@zanker zanker commented Mar 31, 2015

@tarcieri going to merge on green just as a fyi

Looking at Excon's code, they only time they don't raise is on read will block and not on writes (until my change) where I technically broke it.

I'm still going to add this as a just in case, since the Ruby docs mention it.

@tarcieri
Copy link
Member

LGTM

zanker added a commit that referenced this pull request Mar 31, 2015
Make sure we catch WaitWritable for SSL
@zanker zanker merged commit 1d99f1d into httprb:master Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants