[WIP] Convert async I/O backend to Socketry #377
Conversation
| reset_timer | ||
| rescue IOError, SocketError, SystemCallError => ex | ||
| rescue Socketry::Error => ex |
There was a problem hiding this comment.
There are probably more places this sort of change needs to be made
| # @param (see #initialize) | ||
| # @return [void] | ||
| def start_tls(req, options) | ||
| return unless req.uri.https? && !failed_proxy_connect? |
There was a problem hiding this comment.
Not sure why the failed_proxy_connect? call is needed here, but I'm guessing it's related to some of the SSL + proxy test failures.
There was a problem hiding this comment.
I suspect it is, I didn't add that at least.
|
Note: Socketry's timeouts can subsume Some changes to the timeout API will probably be necessary. |
|
Note per cb420da this is a breaking change which will require a new major release (3.x) as among other things it will require Ruby 2.2+ due to the Socketry dependency. Since Rails 5 is also 2.2+, hopefully this is ok. |
tarcieri
force-pushed
the
socketry
branch
5 times, most recently
from
47425bd to
39473ae
Compare
|
Well, still a WIP (especially timeout support) but it's passing consistently on 2.3 and JRuby 9.1.6.0 (and sporadically on 2.2) |
tarcieri
force-pushed
the
socketry
branch
2 times, most recently
from
75456c5 to
abcccba
Compare
Socketry is a high-level socket library which uses async I/O to implement thread-safe timeouts: https://github.com/socketry/socketry Socketry requires Ruby 2.2.6+ JRuby version is bumped to 9.1.6.0 as JRuby has various async I/O bugs on earlier versions, and this is the first release that seems solid async I/O-wise
|
If anyone wants to resume work on this, let me know. |
Socketry uses async I/O to implement thread-safe timeouts:
https://github.com/socketry/socketry
cc @ixti @zanker @TiagoCardoso1983