Make keep_alive_timeout configurable #405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This CI failure is unrelated to the changes. |
ixti
requested changes
Apr 12, 2017
| @@ -138,8 +140,11 @@ def timeout(klass, options = {}) # rubocop:disable Style/OptionHash | |||
| # | |||
| # @yieldparam [HTTP::Client] client Persistent client | |||
| # @return [Object] result of last expression in the block | |||
| def persistent(host) | |||
There was a problem hiding this comment.
We officially support ruby 2.0+, so it's better to use kwargs in here:
def persistent(host, timeout: nil)
# ...
spec/lib/http_spec.rb
Outdated
| context "with timeout specified" do | ||
| subject { HTTP.persistent host, :timeout => 100 } | ||
| it "sets keep_alive_timeout" do | ||
| options = subject.default_options |
There was a problem hiding this comment.
use named subject please:
subject(:client) { HTTP.persistent ... }
# ...
options = client.default_options| @@ -1,3 +1,4 @@ | |||
| # coding: utf-8 | |||
Allow keep_alive_timeout to be set in persistent:
HTTP.persistent("http...", timeout: 120)
nestegg
force-pushed
the
configurable_keepalive_timeout
branch
from
2056ab7
to
8bb2a6c
Compare
|
This has been updated. |
ixti
approved these changes
Apr 13, 2017
|
Merged as 4738d22 |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Jun 5, 2017
## 2.2.2 (2017-04-27) * [#404](httprb/http#404), [#405](httprb/http#405) Make keepalive timeout configurable. ([@nestegg])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow keep_alive_timeout to be set in persistent:
HTTP.persistent("http...", timeout: 120)