Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling on stream reading #27

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 13, 2023

Q A
Bug fix? yes
New feature? no
Breaks BC? no
Fixed issues -

See php-http/psr7-integration-tests#74

@devanych devanych merged commit 3a85d2b into httpsoft:master Nov 15, 2023
13 checks passed
@vjik vjik deleted the improve branch November 15, 2023 08:25
@stof
Copy link

stof commented Nov 15, 2023

The current PR relies on having a throwing error handler being registered before calling this code. It won't solve the issue with the default error handling of PHP.

@devanych
Copy link
Member

@stof yes thank you. Will be fixed in this PR: #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants