-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CircleCI #364
Conversation
9711e31
to
cf5d799
Compare
Tests in macOS, iOS & tvOS are green. On Linux we have a failing test: IOSafetyTests.testStopWithActiveConnections with the following message: failed - 1: bindFailed("Address already in use") With the first observation around it, I think something is not properly working with |
49bbb6a
to
f15e84a
Compare
• Add the new circle.yml file with testing for tvOS, macOS and iOS and SPM for Linux and macOS • Reorganize the tests targets and replace the `import` for the `@testable` in the test targets • Add the test target in the Package.swift • Include the LinuxMain for the SPM run the tests on Linux • Fix the issue with the use of Darwing in Linux
f15e84a
to
2a2ef09
Compare
The current failing test IMHO is very low priority as I'm afraid is a problem with the platform and how GCD and Semaphores are working in Linux. For the moment I'll remove it from the running tests in Linux and we can open an issue and come back to fix it later at some point. The issue number is #366. |
@adamkaplan When you have time can you take a look, please ? With this PR we can ensure stability in our coming PRs. |
@adamkaplan 🙏 Please when you have time can you take a look? |
I'm merging this as this would not break compatibility and it has been in review for some time now. We had an issue opened to track the failing test in Linux. We can rollback in case of an issue. |
Add support for CircleCI
This PR adds support for CI using CircleCI and can be resumed in the following:
import
for the@testable
in the test targets.LinuxMain.swift
for the SPM run the tests on Linux.Darwing
in Linux.This PR is currently a work in progress to solve #349.