Integrate Danger and Swiftlint to the project #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vkt0r
force-pushed
the
danger
branch
2 times, most recently
from
70581d1 to
2094527
Compare
Generated by 🚫 Danger |
Vkt0r
force-pushed
the
danger
branch
24 times, most recently
from
34d1fe7 to
695c4d7
Compare
Vkt0r
changed the title
|
This is ready to go! |
Vkt0r
requested review from
damian-kolakowski,
adamkaplan,
ignatovSA,
julien-c,
marcc-orange,
mbarnach and
pvzig
* Include the Run Script Phase to use Swiftlint in the project with the `.swiftlint.yml` * Fix all the errors and warnings regarding Swiftlint violations
* Add jobs to run Danger as part of the CI * Add the `Dangerfile` with some basics rules for the project * Add the `Gemfile` to manage the Ruby dependencies
* Move the Source dir into the Xcode folder project to be more easy to lint directly Swiftlint * Set the correct path in the XCTManifest
adamkaplan
approved these changes
Apr 22, 2019
|
Fantastic |
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
Integrate Danger and Swiftlint to the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should enable Swiftlint in the project and add Danger for code reviews. Can be resumed in the following:
.swiftlint.ymlDangerfilewith some basics rules for the projectXCTManifestforSources