-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes HttpResponse html(String) behaviour #412
Conversation
Generated by 🚫 Danger |
@ChristianSteffens Thanks for taking the time to create this PR! I think it makes sense to have the ability to provide a full HTML string and not the only the body as you mentioned. This change would break compatibility but I think it's really low compared with the advantage of having both options (body and full HTML). Can you please update the |
I updated the tests. |
@ChristianSteffens Thanks can you please rebase it and get rid of the conflict? I would happily merge it after that. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks.
Changes HttpResponse html(String) behaviour
This PR makes two changes:
CHANGELOG.md
andREADME.md
to the Xcode-Project for easy accessHttpResponse
casehtml
: This case now needs a full html-string (not only the body-part). For compatibility reason we added ahtmlBody
case as well, that case will only need the body-part then.We need to provide a full html-string (with a custom head section), unfortunately the existing
html
case inHttpResonse
always provides a fix head-part (that is probably perfectly fine for most cases).As this PR makes this version incompatible to previous ones in terms of the
html
response I would certainly understand any vetos. Then again the case is calledhtml
and nothtmlBody
so it is / might be misleading anyhow - so IMHO would recommend changing the behaviour as this PR provides.