Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ** not matching single path segment #504

Closed
wants to merge 2 commits into from

Conversation

michaelenger
Copy link
Contributor

Fixes #488.

When we reache the ** node we're at the path segment it is going to match against. The currentIndex is incremented on line 125 which means that we're going to continue checking from the next segment over. So if we increment again before we go into the while loop we've skipped over one and will fail to match the end of the path against our pattern.

@swifter-bot
Copy link

swifter-bot commented Sep 29, 2021

2 Warnings
⚠️ It seems like you've added new tests to the library. If that's the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @michaelenger 👋.

Generated by 🚫 Danger

@michaelenger michaelenger requested a review from Vkt0r September 29, 2021 17:23
tomieq added a commit to tomieq/swifterfork that referenced this pull request Aug 19, 2022
@michaelenger
Copy link
Contributor Author

Closing this as it's clear it won't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'**' does not work with single path element
2 participants