Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring RFC2818 into semantics (Mnot 236) #249

Merged
merged 20 commits into from
Nov 3, 2019
Merged

Bring RFC2818 into semantics (Mnot 236) #249

merged 20 commits into from
Nov 3, 2019

Conversation

mnot
Copy link
Member

@mnot mnot commented Sep 3, 2019

Fixes #236

@mnot mnot requested review from reschke and royfielding September 3, 2019 02:17
@mnot
Copy link
Member Author

mnot commented Sep 3, 2019

I think I've brought the relevant parts across into what seems like the appropriate sections; haven't modified text very much at all. The text that I didn't bring over didn't seem to add much, but I'm happy to be talked around on that.

N.B. we'll need to update the reference from 5246 to 8446 in semantics, but that's separable (and I assume we'll do a reference sweep when we're closer to done anyway).

@reschke reschke changed the title Mnot 236 Bring RFC2818 into semantics (Mnot 236) Sep 3, 2019
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all the parts are in the right place. Worked a bit on the boilerplate.

I note that in the inserted text, terms from RFC 5280 are used before it's first mention. Separate ticket, or should we try to fix this right now?

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and we'll have to ACK the authors of 2818.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this is just imported text, so keeping the text as-is is a totally legitimate choice.

draft-ietf-httpbis-messaging-latest.xml Show resolved Hide resolved
</t>
<t>
If the hostname does not match the identity in the certificate, user
oriented clients MUST either notify the user (clients MAY give the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user-oriented, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a "user(-)oriented client" different from a "user agent"?

@mnot
Copy link
Member Author

mnot commented Sep 30, 2019

ACK'd. I think additional issue should be separate. PTAL.

Copy link
Member

@royfielding royfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on this. The PR doesn't quite do what we want, since the normative parts of RFC2818 are actually in the introductory material that was left out, and placing all of the server identification bits in a security section doesn't make sense. I will move it to a subsection of https and then start working on the related issues for establishing https authority.

@royfielding royfielding merged commit a553980 into master Nov 3, 2019
@royfielding royfielding deleted the mnot-236 branch November 3, 2019 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bring RFC2818 into semantics
4 participants